build-script-impl: Don't let distcc farm out cmake to run on other machines. #6763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chines. If cmake is run on another machine, the default Xcode path and more in the cmake cache and ninja files will be of that machine's configuration, not the local machine's. Test with: ./utils/build-script -r -- --distcc --verbose The cmake lines should start with ``/usr/local/bin/cmake`` instead of with ``/opt/distcc/pump``. rdar://problem/29942258
|
@swift-ci Please smoke test |
|
@gottesmm What do you think about the above patch idea? |
|
@erg That was the original intention of that line. So I am all for this. We should make sure that this still solve's DaveA's issue before we continue though. |
|
None of the changes we're making now make sense to me. Maybe we should wait until we can discuss this in person. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.