Fix @_rawLayout initialization to avoid spurious lifetime ends.
#67633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
We can't really treat them as always-initialized because that makes move checking think that there's a value to destroy even on initialization, causing deinits to run on uninitialized memory. Remove my previous hack, and use a `zeroInitializer` to initialize the value state when emitting `init`, which is where we really need the bootstrapping-into-initialized behavior. rdar://113057256
jckarter
force-pushed
the
raw-layout-initialization
branch
from
e264df6 to
9b78356
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't really treat them as always-initialized because that makes move checking think that there's a value to destroy even on initialization, causing deinits to run on uninitialized memory. Remove my previous hack, and use a
zeroInitializerto initialize the value state when emittinginit, which is where we really need the bootstrapping-into-initialized behavior. rdar://113057256