Sema: Fix unavailable enum element cases in derived hashable/equatable impls #67636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cases. Also, add a FIXME to track improving the diagnostics when derivation of a Comparable conformance is blocked by unavailable enum cases.
The `-unavailable-decl-optimization` flag is a frontend flag and therefore requires `-Xfrontend` when passed through the driver.
Unavailable cases _can_ be written in switch statements. However, they should not be required to be written for exhaustive matching.
tshortli
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
No test changes because the tests for `-print-ast` don't match whitespace.
…e impls. When deriving the `hash(into:)` and `==` witnesses for `Hashable`/`Equatable` enums, call `_diagnoseUnavailableCodeReached()` in the case bodies for unavailable enum elements. This is needed because the previously derived code would operate on the values associated with unavailable enum elements, which is illegal if the types of those associated values are also unavailable (these case bodies would have failed typechecking had they been hand-written). The new structure also more explicitly documents that reaching these cases is unexpected, since unavailable enum elements should not be instantiated at run time.
tshortli
force-pushed
the
enum-unavailable-element-derived-equatable-hashable
branch
from
835e142 to
e4810f5
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
tshortli
deleted the
enum-unavailable-element-derived-equatable-hashable
branch
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Aug 24, 2023
…ormance. Fixes a regression caused by swiftlang#67636 in which the patterns for case statements generated to match unavailable enum elements were missing a type. The missing type caused a crash during SILGen if the unavailable element case was the first one in the swtich statement. Resolves rdar://113761850
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deriving the
hash(into:)and==witnesses forHashable/Equatableenums, call_diagnoseUnavailableCodeReached()in the case bodies for unavailable enum elements. This is needed because the previously derived code would operate on the values associated with unavailable enum elements, which is illegal if the types of those associated values are also unavailable (these case bodies would have failed typechecking had they been hand-written). The new structure also more explicitly documents that reaching these cases is unexpected, since unavailable enum elements should not be instantiated at run time.Includes some drive-by fixes for other tests exercising enums with unavailable elements.