Skip to content

[Compile Time Constant Extraction] Deprecated extraction of property mangled names #67658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Aug 1, 2023

It can often be more complex than the code can currently handle (e.g. properties whose types include archetypes), and we do not have a good motivating use-case to extract them.

Resolves rdar://113039215

@artemcm artemcm requested a review from nkcsgexi August 1, 2023 21:09
@artemcm
Copy link
Contributor Author

artemcm commented Aug 1, 2023

@swift-ci test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to keep it simple👍.

…mangled

names. It can often be more complex than the code can currently handle (e.g.
properties whose types include archetypes), and we
do not have a good motivating use-case to extract them.

Resolves rdar://113039215
@artemcm artemcm force-pushed the NoPropertyMangledNameConstExtract branch from 9446df7 to 0ea41ef Compare August 1, 2023 22:53
@artemcm
Copy link
Contributor Author

artemcm commented Aug 1, 2023

@swift-ci test and merge

@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Linux platform

@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Linux platform

@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Linux platform

@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Windows platform

@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Linux platform

1 similar comment
@artemcm
Copy link
Contributor Author

artemcm commented Aug 2, 2023

@swift-ci test Linux platform

@artemcm artemcm merged commit 77e694a into swiftlang:main Aug 2, 2023
@artemcm artemcm deleted the NoPropertyMangledNameConstExtract branch August 2, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants