Skip to content

Fail cleanly for certain invalid manglings #67667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented Aug 2, 2023

There are certainly more such issues in this code, but this is one that was recently reported.

While here, re-enable some disabled test cases that currently pass.

Resolves rdar://104671103

There are certainly more such issues in this code, but this is
one that was recently reported.

While here, re-enable some disabled test cases that currently pass.

Resolves rdar://104671103
@tbkka tbkka requested a review from al45tair August 2, 2023 01:20
Copy link
Contributor

@al45tair al45tair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I notice we have a few tests with the -> versus ---> problem still; presumably they only "work" because they're missing the $ from the front as well?

@tbkka
Copy link
Contributor Author

tbkka commented Aug 2, 2023

@swift-ci Please test

@tbkka
Copy link
Contributor Author

tbkka commented Aug 2, 2023

Test lines that do not use ---> are ignored entirely. I looked at re-enabling all such tests, but a number of them still fail. Obviously, we should look into those.

@tbkka
Copy link
Contributor Author

tbkka commented Aug 2, 2023

@swift-ci Please test Linux

@tbkka tbkka merged commit 7ded73b into swiftlang:main Aug 2, 2023
@tbkka tbkka deleted the tbkka-rdar104671103 branch August 1, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants