[OpaqueValues] Skip temporary when loading l-value base. #67687
Merged
+30
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
@swift-ci please test macos platform |
1 similar comment
|
@swift-ci please test macos platform |
When emitting key-path functions on behalf of a base that's an l-value, copy the l-value into a temporary only when using lowered addresses.
nate-chandler
force-pushed
the
opaque-values/20230802/1/no-temporary-for-lvalue-keypath-base
branch
from
006775d to
4c6fc1a
Compare
|
@swift-ci please test |
|
@swift-ci please test linux platform |
|
@swift-ci please test macos platform |
|
@swift-ci please test linux platform |
1 similar comment
|
@swift-ci please test linux platform |
nate-chandler
deleted the
opaque-values/20230802/1/no-temporary-for-lvalue-keypath-base
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When emitting key-path functions on behalf of a base that's an l-value, copy the l-value into a temporary only when using lowered addresses.