Go back to using static inline stubs for sqrt and remainder #6769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now that SR-2089 is resolved.
|
@swift-ci Please test. |
|
Can you add a test that shows the constant-folding does happen under -O? |
|
@jrose-apple yes, but it'll need to wait until I'm on a machine where I can actually build and run tests =) I'll take a look at it tomorrow. |
|
@moiseev very straightforward, but please sanity-check. |
jrose-apple
reviewed
Jan 13, 2017
|
|
||
| public func test6( ) -> Double { | ||
| return sqrt(4) | ||
| } |
There was a problem hiding this comment.
I guess since we're worried about LLVM's sqrt, is it worth adding a test for sqrt(-1) not becoming undef or something?
There was a problem hiding this comment.
I think the earlier CHECK-NOT llvm.sqrt probably covers us, but I can definitely add one.
|
@swift-ci Please test. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally planned to have these be static inline, but had to back that out due to SR-2089. That's resolved now though, so this should work, and allow constant folding through square root and remainder.
rdar://problem/30004033