[Linux] Set rpath in add_swift_executable. #67711
Conversation
Because the rpath isn't set, the dynamic linker can't find the Swift libraries when we try to run `swift-backtrace` on Linux (when we actually install everything). rdar://113337854
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Windows platform |
|
@swift-ci Please smoke test macOS platform |
|
@swift-ci Please smoke test Windows platform |
|
@swift-ci Please smoke test macOS platform |
| elseif(SWIFT_HOST_VARIANT_SDK STREQUAL "LINUX") | ||
| set_target_properties(${name} PROPERTIES | ||
| BUILD_WITH_INSTALL_RPATH YES | ||
| INSTALL_RPATH "$ORIGIN/../../../lib/swift/${SWIFT_SDK_${SWIFTEXE_SINGLE_SDK}_LIB_SUBDIR}") |
There was a problem hiding this comment.
This will add this relative rpath to all target executables on linux, like swift-reflection-test, so it seems mistaken. Better to pass in a relative path, like _add_swift_runtime_link_flags() does with relpath_to_lib_dir.
There was a problem hiding this comment.
swift-reflection-test isn't ever installed, and the rpath set there doesn't matter. If it was installed, it would be put into libexec and in that case it would also need this rpath.
There was a problem hiding this comment.
True, it isn't installed now.
|
@swift-ci Please smoke test Windows platform |
1 similar comment
|
@swift-ci Please smoke test Windows platform |
Because the rpath isn't set, the dynamic linker can't find the Swift libraries when we try to run
swift-backtraceon Linux (when we actually install everything).rdar://113337854