🌲Some final build fixes #67714
Merged
🌲Some final build fixes #67714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a few more missing headers. Adding them in now.
I accidentally added a test for an experiment that I was doing earlier on. Removing that now because it doesn't build.
strlen on a StringRef doesn't work. Replacing it.
Optional changed to std::optional, so there is no hasValue. Replacing it so that it builds.
etcwilde
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor and
rintaro
as code owners
bnbarham
reviewed
Aug 3, 2023
| @@ -27,7 +27,7 @@ testHasOption(llvm::opt::OptTable &table, options::ID id, | |||
| const std::unordered_set<std::string> &optionSet) { | |||
| if (table.getOption(id).hasFlag(swift::options::FrontendOption)) { | |||
| auto name = table.getOptionName(id); | |||
| if (strlen(name) > 0) { | |||
| if (!name.empty() && name[0] != '\0') { | |||
There was a problem hiding this comment.
This is just due to the option changes again, !name.empty() here is fine IMO. I know a StringRef can contain \0 but it's not going to happen here.
bnbarham
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some final build fixes to get things building for testing. We get to testing, but there are some bits in clang that are hanging forever. We don't want to eat the bots alive, so I'm not sure that we want to fire off the tests just yet. We also need swiftlang/llvm-project#7137 to test or we won't find gtest.