Sema: NSValue-to-value-type casts are failable and should be checked. #6774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@DougGregor and @rudkx, do you mind reviewing this? |
rudkx
approved these changes
Jan 13, 2017
| @@ -5394,6 +5411,8 @@ Expr *ExprRewriter::buildObjCBridgeExpr(Expr *expr, Type toType, | |||
| ConstraintLocatorBuilder locator) { | |||
| Type fromType = cs.getType(expr); | |||
|
|
|||
| // Warn in Swift 3 mode if a coercion goes from | |||
There was a problem hiding this comment.
Fixed, thanks Mark!
In Swift 4 mode, no longer consider e.g. 'nsNumber as Int' or 'nsValue as NSRange' to be valid coercions. This would break compatibility with Swift 3, so in Swift 3 mode, accept the coercion, but *also* accept a checked cast without a warning, and raise a migration warning about the unchecked coercion.
jckarter
force-pushed
the
nsnumber-conditional-casting
branch
from
c258bb1 to
c03371a
Compare
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 4 mode, no longer consider e.g. 'nsNumber as Int' or 'nsValue as NSRange' to be valid coercions. This would break compatibility with Swift 3, so in Swift 3 mode, accept the coercion, but also accept a checked cast without a warning, and raise a migration warning about the unchecked coercion.