[SILGen] Unified Entry Point Emission #67747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachary-kent
requested review from
zoecarver,
hyp,
egorzhdan and
adrian-prantl
as code owners
|
@swift-ci please test |
slavapestov
reviewed
Aug 4, 2023
lib/SILGen/SILGenTopLevel.h
Outdated
|
|
||
| namespace Lowering { | ||
|
|
||
| /// Generates a `SILFunction` for toplevel code |
There was a problem hiding this comment.
A bit more detail would be nice; script mode, TopLevelCodeDecl, global variable initializers, etc
There was a problem hiding this comment.
Makes sense, thanks! Does it look better now?
zachary-kent
force-pushed
the
sil-gen-top-level
branch
from
1abfee9 to
64dfd7c
Compare
zachary-kent
force-pushed
the
sil-gen-top-level
branch
from
2b1c9f3 to
913b717
Compare
|
@swift-ci please test |
slavapestov
approved these changes
Aug 4, 2023
|
@swift-ci Please test source compatibility |
zachary-kent
force-pushed
the
sil-gen-top-level
branch
from
6e48c36 to
d828a48
Compare
|
@swift-ci Please test source compatibility |
|
@swift-ci please test |
hamishknight
approved these changes
Aug 8, 2023
|
@swift-ci please test |
added 8 commits
August 8, 2023 11:25
Implement SILGenTopLevel, a class that walks a file run in script mode to generate all toplevel code at once.
Emit SILDeclRefs representing entry points with SourceFile source correctly.
Emit SILDeclRefs representing entry points with SourceFile source correctly.
zachary-kent
force-pushed
the
sil-gen-top-level
branch
from
9e27d4f to
db1cdbd
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements unified entry point emission in SILGen so that all top level code is emitted at once. Although this is arguably NFC, I had to modify some tests because all declarations referenced by top-level code are now emitted first during SILGen.