Skip to content

Platform: make stdint module implicit on Windows #67756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Aug 4, 2023

This makes the stdint module implicit which repairs the ability to build some components. In order to accomplish this, we need to potentially break the fragile Swift build system. Due to the incorrect handling of compilers we need some workarounds to support cross-compilation. This removes the injected system header paths when building on Windows to ensure that the clang resource headers are not following the system headers which breaks the modules as the clang resources are dependent on the system headers when running in hosted mode.

This makes the `stdint` module implicit which repairs the ability to
build some components.  In order to accomplish this, we need to
potentially break the fragile Swift build system.  Due to the incorrect
handling of compilers we need some workarounds to support
cross-compilation.  This removes the injected system header paths when
building on Windows to ensure that the clang resource headers are not
following the system headers which breaks the modules as the clang
resources are dependent on the system headers when running in hosted
mode.
@compnerd
Copy link
Member Author

compnerd commented Aug 4, 2023

@swift-ci please smoke test

@compnerd compnerd merged commit 62bd4f2 into swiftlang:main Aug 5, 2023
@compnerd compnerd deleted the stdint branch August 5, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant