AST: Restore unqualified lookup quirk for Swift 3 mode #6777
+67
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
In Swift 3, unqualified lookup would skip static methods when performing a lookup from instance context. In Swift 4 mode, if a module method is shadowed by a static method, you will need to qualify the module method with the module name. It would have been nice to isolate the quirk in Sema and not AST, but unfortunately UnqualifiedLookup only proceeds to lookup in the module if scope-based lookup failed to find anything, and I don't want to change that since it risks introducing performance regressions. Fixes <rdar://problem/29961715>.
slavapestov
force-pushed
the
fix-unqualified-lookup-rdar29961715
branch
from
d28950a to
fbdeceb
Compare
|
@swift-ci Please smoke test |
|
Is it really correct for this to be an error in Swift 4 mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 3, unqualified lookup would skip static methods
when performing a lookup from instance context.
In Swift 4 mode, if a module method is shadowed by a static
method, you will need to qualify the module method with the
module name.
It would have been nice to isolate the quirk in Sema and
not AST, but unfortunately UnqualifiedLookup only proceeds
to lookup in the module if scope-based lookup failed to find
anything, and I don't want to change that since it risks
introducing performance regressions.
Fixes rdar://problem/29961715.