[silgen] Rename forTrivialObjectRValue -> forObjectRValueWithoutOwnership and change a bunch of forUnmanaged to use this API #67780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ship. The reason to do this rename is that this is also used for objects that while non-trivial have .none ownership. Example: enum instance without a case.
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am in the process of attempting to embed a bit into ManagedValue to say if a value is formal access scoped or lexical access scoped. As part of this, I need to get rid of the API forUnmanaged value since it is a way in SILGen that people have historically used to create both lexical and formal access scoped borrowed values. This also means I need to cleanup other usages of forUnmanaged value as well. As part of that in this PR, I am converting a bunch of cases where forUnmanaged was used with values that did not have ownership to instead use forObjectRValueWithoutOwnership.