SwiftCompilerSources: update Package.swift
#67810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
hyp
reviewed
Aug 9, 2023
LLVM, clang, and Swift use C++17. Explicitly specify the C++ language standard to use.
Mark the Swift flags for interoperability mode rather than using the old spelling for enabling C++ interoperability. This is important as it allows the `cxxLanguageStandard` to flow through to the clang importer which is required to enable the use of the C++ headers.
Remove the flags that are now implicitly setup by SPM. Addresses feedback from @hyp.
Use the `cxxSettings` to pass along header search paths. With those removed, we are simply adding the interoperability mode and unsafe flags, which we can inline. This simplifies the package definition a bit.
compnerd
force-pushed
the
interoperation
branch
from
0bade0f to
d171463
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the package manager manifest to properly enable C++ interoperability. This allows us to start trying to build SwiftCompilerSources with SPM again.