[5.9] AST: Get SPI status of PatternBindingDecl from anchoring VarDecl #67812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
added
🍒 release cherry pick
For property declarations, the `@_spi` attribute is attached to the VarDecl AST node, rather than the PatternBindingDecl AST node, so the `isSPI()` query should take this into account. Failing to do so caused the availability checker to erroneously require that `@_spi` properties of types in `-library-level api` libraries have availability annotations. Resolves rdar://113587321.
tshortli
force-pushed
the
spi-property-availability-5.9
branch
from
198462b to
560328f
Compare
|
@swift-ci please test |
nkcsgexi
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_spi publicproperty declarations in-library-level apimodules. The fix is to make theisSPI()query in the compiler look for@_spiattributes attached to theVarDeclAST node associated with a givenPatternBindingDeclAST node.isSPI()query returning true for more declarations could reveal additional typechecking bugs or otherwise break source in projects using@_spi.