Skip to content

Hack to workaround a clang lto bug #6782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/IRGen/AllocStackHoisting.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ insertDeallocStackAtEndOf(SmallVectorImpl<SILInstruction *> &FunctionExits,
}
}

/// Hack to workaround a clang LTO bug.
__attribute__((noinline))
void moveAllocStackToBeginningOfBlock(AllocStackInst* AS, SILBasicBlock *BB) {
AS->removeFromParent();
BB->push_front(AS);
}

/// Assign a single alloc_stack instruction to all the alloc_stacks in the
/// partition.
void Partition::assignStackLocation(
Expand All @@ -120,8 +127,7 @@ void Partition::assignStackLocation(

// Move this assigned location to the beginning of the entry block.
auto *EntryBB = AssignedLoc->getFunction()->getEntryBlock();
AssignedLoc->removeFromParent();
EntryBB->push_front(AssignedLoc);
moveAllocStackToBeginningOfBlock(AssignedLoc, EntryBB);

// Erase the dealloc_stacks.
eraseDeallocStacks(AssignedLoc);
Expand Down