[ASTGen] Allow querying of experimental features #67826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro,
zoecarver,
hborla,
slavapestov and
xedin
as code owners
hamishknight
changed the title
For now this is using C interop, we ought to be using C++ interop, but that's a much bigger change.
hamishknight
force-pushed
the
experimental
branch
from
4c584c1 to
35a98f3
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Aug 9, 2023
Comment on lines
+33
to
+37
| func mapFeature(_ bridged: BridgedFeature, to feature: Self) { | ||
| if ASTContext_langOptsHasFeature(context, bridged) { | ||
| insert(feature) | ||
| } | ||
| } |
There was a problem hiding this comment.
I assume this is a stub to be used once you introduce features that need to be mapped to SwiftParser, correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for swiftlang/swift-syntax#2041 such that experimental features can be enabled in SwiftSyntax.