Skip to content

[lldb] Capture error messages from parseASTSection to log from caller #67833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

hjyamauchi
Copy link
Contributor

This helps fix a lldb console output mixup between the lldb logging and the llvm::dbgs() messages from parseASTSection.

@hjyamauchi
Copy link
Contributor Author

CC @compnerd
This is paired with swiftlang/llvm-project#7198

@compnerd
Copy link
Member

compnerd commented Aug 9, 2023

CC: @xymus

…ller.

This helps fix a lldb console output mixup between the lldb logging
and the llvm::dbgs() messages from parseASTSection.
@hjyamauchi
Copy link
Contributor Author

hjyamauchi commented Aug 11, 2023

Used llvm::Expected. PTAL.

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/llvm-project#7198

@swift-ci please test

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/llvm-project#7198

@swift-ci please test Linux platform

@compnerd compnerd merged commit 73ab168 into swiftlang:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants