[5.9] Sema: Correct availability for @inlinable global var accessors bodies #67851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
tshortli
added
🍒 release cherry pick
tshortli
force-pushed
the
unavailable-inlinable-computed-property-availability-5.9
branch
2 times, most recently
from
9948342 to
2c18fc6
Compare
The bodies of unavailable functions should be typechecked as if they would always run at the deployment target, even if they are `@inlinable`. This was not the case in the bodies of unavailable `@inlinable` global var accessor, though, because the availability of the accessor, rather than enclosing var, was being queried. The fix is to use `getSemanticUnavailableAttr()`. Resolves rdar://113642576
tshortli
force-pushed
the
unavailable-inlinable-computed-property-availability-5.9
branch
from
2c18fc6 to
06265dc
Compare
|
@swift-ci please test |
nkcsgexi
approved these changes
Aug 10, 2023
tshortli
deleted the
unavailable-inlinable-computed-property-availability-5.9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@inlinable. This was not the case in the bodies of unavailable@inlinableglobal var accessors, though, because the availability of the accessor, rather than enclosing var, was being queried. The fix is to usegetSemanticUnavailableAttr().@available, so that mitigates the impact.