[Driver] SR-3175: Include the terminating signal number in the driver output #6787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the signal number of the terminated task to the output of the driver on platforms for which the signal number is available. The new key in the parseable driver output is "signal". * Add a test to verify that the signal number is emitted. * Add documentation for the new "signal" key emitted in the parseable driver output. https://bugs.swift.org/browse/SR-3175
CodaFi
reviewed
Jan 14, 2017
| Diags.diagnose(SourceLoc(), diag::error_command_signalled, | ||
| SignalledCmd->getSource().getClassName(), Signal.getValue()); | ||
| } | ||
| else { |
There was a problem hiding this comment.
Nit: else in line with } please
xwu
reviewed
Jan 14, 2017
| public: | ||
| SignalledMessage(const Job &Cmd, ProcessId Pid, StringRef Output, | ||
| StringRef ErrorMsg) : TaskOutputMessage("signalled", Cmd, | ||
| StringRef ErrorMsg, Optional<int> Signal) : TaskOutputMessage("signalled", Cmd, |
There was a problem hiding this comment.
Nit: with the additional parameter, the alignment of the two lines that follow are totally out of whack.
|
@swift-ci please smoke test. |
|
Whoa, an NPE took down the build! // @shahmishal |
|
@swift-ci please smoke test OS X platform. |
|
Can you knock off the merge commit either by folding it into the previous one or by cherry-picking @hughbe's branch please? |
(cherry picked from commit ff17c26) swiftlang#6812
matthewcarroll
force-pushed
the
SR-3175-Include-signal-number-in-parseable-output-message
branch
from
81bf314 to
09abbfe
Compare
|
@swift-ci please smoke test. |
1 similar comment
|
@swift-ci please smoke test. |
|
Is this PR ready to go? Merging will unblock the Windows (clang and MSVC) build |
|
⛵️ |
matthewcarroll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.swift.org/browse/SR-3175
In this commit, example output of swiftc -Xfrontend -debug-crash-immediately is: