[cxx-interop] Make sure to create empty initializers for C++ structs #67873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
hyp
approved these changes
Aug 10, 2023
egorzhdan
force-pushed
the
egorzhdan/pthread_mutexattr_t
branch
from
d3770b3 to
5cfd426
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/pthread_mutexattr_t
branch
from
5cfd426 to
b33ab5f
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/pthread_mutexattr_t
branch
from
b33ab5f to
fdc029b
Compare
|
@swift-ci please smoke test |
The existing synthesis mechanism had a bug: `cxxRecordDecl->hasDefaultConstructor()` returns true for C++ types with an implicit default constructor, for instance, `pthread_mutexattr_t`. rdar://113708880
egorzhdan
force-pushed
the
egorzhdan/pthread_mutexattr_t
branch
from
fdc029b to
4eb9c3b
Compare
|
@swift-ci please smoke test |
hyp
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing synthesis mechanism had a bug:
cxxRecordDecl->hasDefaultConstructor()returns true for C++ types with an implicit default constructor, for instance,pthread_mutexattr_t.rdar://113708880