[semantic-sil] Use SILGenFunction::emitManagedBufferWithCleanup instead of entering in a random cleanup. #6792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of entering in a random cleanup. This is a small cleanup where we are creating a cleanup for an uninitialized buffer that will be verified as initialized later by DI and then creating a +0 unmanaged ManagedValue for the value. This violates the "norms" of using ManagedValue in SILGen which is that one should use the SILGenFunction::emitManaged* methods for creating/propagating cleanups around.
|
Hey Joe. I am pretty sure this is correct, but I want to get another set of eyes to look at this. The only reason I can think that this would be incorrect is if in general we do not propagate the cleanups for uninitialized things that DI will handle. |
|
@swift-ci Please test |
|
@ ed you. |
|
Seems reasonable. It definitely looks fishy the way it is. |
|
Thanks Joe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[semantic-sil] Use SILGenFunction::emitManagedBufferWithCleanup instead of entering in a random cleanup.
This is a small cleanup where we are creating a cleanup for an uninitialized
buffer that will be verified as initialized later by DI and then creating a +0
unmanaged ManagedValue for the value.
This violates the "norms" of using ManagedValue in SILGen which is that one
should use the SILGenFunction::emitManaged* methods for creating/propagating
cleanups around.