[5.9][CSSimplify] Relax isBindable requirements for pack expansion variables #67935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olvePackExpansion` The type variable should always be one for pack expansion type which implies that locator always ends at `PackExpansionType`. (cherry picked from commit 043d2aa)
…extual type This is effectively a premature optimization. Contextual type might not be fully resolved yet, so let's give solver a chance to do it for us. (cherry picked from commit 3dff3e5)
…bles If type variable we are about to bind represents a pack expansion type, allow the binding to happen regardless of what the \c type is, because contextual type is just a hint in this situation and type variable would be bound to its opened type instead. Resolves: rdar://112617922 (cherry picked from commit 27413f5)
|
@swift-ci please test |
hborla
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #67759
If type variable we are about to bind represents a pack
expansion type, allow the binding to happen regardless of
what the \c type is, because contextual type is just a hint
in this situation and type variable would be bound to its
opened type instead.
Scope: Some expressions with variadic generics that reference associated types.
Main Branch PRs: [CSSimplify] Relax
isBindablerequirements for pack expansion variables #67759Resolves: rdar://112617922
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the suite.
Resolves: rdar://112617922