Skip to content

Runtime: Lift prohibition on packs in swift_getTypeByMangledName() overload used by mirrors [5.9] #67937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2023
Merged

Runtime: Lift prohibition on packs in swift_getTypeByMangledName() overload used by mirrors [5.9] #67937

merged 1 commit into from
Aug 15, 2023

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Aug 15, 2023 •
edited
Loading

  • Description: Fixes a runtime crash when printing a variadic generic type due to an untested code path in mirrors.
  • Origination: Never worked.
  • Risk: Low, this just disables an assertion by changing one accessor method call for another.
  • Tested: Execution test added.
  • Radar: rdar://problem/112866068.
  • Reviewed by: @hborla

@slavapestov
Runtime: Lift prohibition on packs in swift_getTypeByMangledName() ov…
b797a87 
…erload used by mirrors

Fixes rdar://problem/112866068.
@slavapestov slavapestov requested a review from a team as a code owner August 15, 2023 16:09
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov slavapestov merged commit f26a173 into swiftlang:release/5.9 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @hborla