A pile of mostly unrelated one-liners #67952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Experimental mode for generating module interfaces without running primary file type-checking. The idea is that the ASTPrinter triggers requests to only do the minimum amount of type checking work possible while printing the interface for a module's public declarations. These requests may emit diagnostics, but the ASTPrinter should in theory already be robust against invalid code.
slavapestov
force-pushed
the
tuple-conformance-tbd-etc
branch
from
093b0cb to
97ee4e3
Compare
tshortli
approved these changes
Aug 16, 2023
slavapestov
force-pushed
the
tuple-conformance-tbd-etc
branch
from
97ee4e3 to
cb07d39
Compare
|
@swift-ci Please test |
slavapestov
force-pushed
the
tuple-conformance-tbd-etc
branch
from
cb07d39 to
1db4ff6
Compare
|
@swift-ci Please smoke test |
Type-checking patterns is not fully requestified, so the ASTPrinter should not assume this has been filled in. It appears sufficient to just visit the associated VarDecl, as we do already.
slavapestov
force-pushed
the
tuple-conformance-tbd-etc
branch
from
1db4ff6 to
bea1ba4
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has some preliminary work to make TBD and swiftinterface generation lazier, and a bonus set of IRGen tuple conformances fixes.