Mark several C macros imported from <float.h> as deprecated. #6796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These macros all have straightforward replacements in terms of static properties on FloatingPoint or BinaryFloatingPoint. It is necessary to add 1 in a few places because of differences between how C and Swift count significand bits and normalize the significand, but this is expected to have minimal impact on code in practice (and when it does have impact, using the Swift definition is generally simpler).
|
@swift-ci Please test |
moiseev
suggested changes
Jan 13, 2017
.| @available(swift, deprecated: 3.0, message: "Please use 'T.radix' to get the radix of a FloatingPoint type 'T'.") | ||
| public let FLT_RADIX = Double.radix | ||
|
|
||
| %for type in ["Float","Double","Float80"]: |
There was a problem hiding this comment.
May I suggest:
for type, prefix in [('Float', 'FLT'), ('Double', 'DBL'), ('Float80', 'LDBL')]:| public let ${prefix}_MANT_DIG = ${type}.significandBitCount + 1 | ||
|
|
||
| // Where does the 1 come from? C models floating-point numbers as having a | ||
| // significand in [0.5, 1), but Swift (follwing IEEE 754) considers the |
|
|
||
| %for type in ["Float","Double","Float80"]: | ||
| % prefix = {"Float":"FLT","Double":"DBL","Float80":"LDBL"}[type] | ||
| % implicit = "implicit " |
There was a problem hiding this comment.
I don't see ${implicit} being used anywhere. Does it belong in the comment?
|
|
||
| _ = FLT_MANT_DIG // expected-warning {{is deprecated}} | ||
| _ = DBL_MANT_DIG // expected-warning {{is deprecated}} | ||
| _ = LDBL_MANT_DIG // expected-warning {{is deprecated}} |
There was a problem hiding this comment.
Shouldn't it be surrounded by #if arch(i386) || arch(x86_64) ... #endif?
|
Also, could you please mention the radar (rdar://problem/27871465) in the commit message? |
|
@swift-ci please test |
moiseev
approved these changes
Jan 14, 2017
|
Reverting in #6817. The FloatConstants test is failing on iOS. The test is incorrectly written for architectures that aren't i386 or x86_64; the verifier still expects the long double warnings and (correctly) doesn't get them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These macros all have straightforward replacements in terms of static properties on FloatingPoint or BinaryFloatingPoint. It is necessary to add 1 in a few places because of differences between how C and Swift count significand bits and normalize the significand, but this is expected to have minimal impact on code in practice (and when it does have impact, using the Swift definition is generally simpler).
rdar://problem/27871465