Skip to content

[5.9] [SE-0400] SE-0400: Enable InitAccessors feature by default #67963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DougGregor
Copy link
Member

@DougGregor DougGregor commented Aug 16, 2023

This feature was accepted, so remove it as an "experimental feature" and enable it by default. Fixes rdar://113708096.

@DougGregor DougGregor requested a review from a team as a code owner August 16, 2023 16:15
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor force-pushed the init-accessors-is-not-experimental-5.9 branch from 3352baf to b1fc600 Compare August 16, 2023 19:33
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor changed the title [Test-only fix] [5.9] Remove unnecessary --enable-experimental-feature InitAccessors from tests [5.9] [SE-0400] SE-0400: Enable InitAccessors feature by default Aug 16, 2023
xedin and others added 2 commits August 16, 2023 14:38
… tests

This feature was accepted, so we no longer need to pass this flag. Worse,
it triggers errors in non-Asserts compilers. Fixes rdar://113708096.
@DougGregor DougGregor force-pushed the init-accessors-is-not-experimental-5.9 branch from b1fc600 to d5b29e6 Compare August 16, 2023 21:49
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

(fixed a bad cherry-pick)

@DougGregor DougGregor merged commit 0664218 into swiftlang:release/5.9 Aug 17, 2023
@DougGregor DougGregor deleted the init-accessors-is-not-experimental-5.9 branch August 17, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants