Skip to content

[AST] Update source module correction logic to support @_spiOnly imports #67970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/AST/ASTPrinter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5851,6 +5851,11 @@ class TypePrinter : public TypeVisitor<TypePrinter> {
// For the current module, consider both private and public imports.
ModuleDecl::ImportFilter Filter = ModuleDecl::ImportFilterKind::Exported;
Filter |= ModuleDecl::ImportFilterKind::Default;

// For private swiftinterfaces, also look through @_spiOnly imports.
if (Options.PrintSPIs)
Filter |= ModuleDecl::ImportFilterKind::SPIOnly;

SmallVector<ImportedModule, 4> Imports;
Options.CurrentModule->getImportedModules(Imports, Filter);

Expand Down
43 changes: 43 additions & 0 deletions test/SPI/spi-only-swiftinterface-and-merged-decls.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/// Check that we correctly refer to @_spiOnly imported modules in the private
/// swiftinterface and not to one of the redeclarations.
// REQUIRES: objc_interop

// RUN: %empty-directory(%t)
// RUN: split-file %s %t

// RUN: %target-swift-frontend -emit-module %t/Client.swift -I %t \
// RUN: -enable-library-evolution -swift-version 5 \
// RUN: -experimental-spi-only-imports \
// RUN: -emit-module-interface-path %t/Client.swiftinterface \
// RUN: -emit-private-module-interface-path %t/Client.private.swiftinterface

// RUN: %target-swift-typecheck-module-from-interface(%t/Client.swiftinterface) -I %t

/// We print a reference to A in the private swiftinterface.
// RUN: %FileCheck %s < %t/Client.private.swiftinterface
// RUN: %target-swift-typecheck-module-from-interface(%t/Client.private.swiftinterface) -I %t \
// RUN: -module-name Client

//--- module.modulemap
module A {
header "A.h"
}

module B {
header "B.h"
}

//--- A.h
@interface MovingType
@end

//--- B.h
@class MovingType;

//--- Client.swift
import B
@_spiOnly import A

@_spi(_)
public func foo(_ a: MovingType) {}
// CHECK: A.MovingType