Revert "AST: Spot fix for AbstractStorageDecl::isResilient()" #67972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d5b354f. It causes miscompiles when accessing properties declared with `@_originallyDefinedIn` that are now defined in modules with library evolution enabled from the module that the property was originally defined in. Just because the property used to be declared in the current module doesn't mean it can bypass the stable ABI of the module that the property now belongs to. It looks like the logic that this PR replaced is also faulty, since `@_originallyDefinedIn` really oughtn't factor into the resilience computation at any level, but let's unwind one level of brokenness at a time. Fixes rdar://113935401.
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d5b354f. It causes miscompiles when accessing properties declared with
@_originallyDefinedInthat are now defined in modules with library evolution enabled from the module that the property was originally defined in. Just because the property used to be declared in the current module doesn't mean it can bypass the stable ABI of the module that the property now belongs to.It looks like the logic that this PR replaced is also faulty, since
@_originallyDefinedInreally oughtn't factor into the resilience computation at any level, but let's unwind one level of brokenness at a time.Fixes rdar://113935401.