Frontend: Migrate several options to no longer be ignorable in swiftinterfaces #67980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erfaces. Frontend options should only be printed under `swift-module-flags-ignored:` temporarily to prevent condfails for older development compilers that are still in use (as a rule of thumb, swiftinterfaces should be compatible with compilers that are up to 6 months old). None of the frontend flags that are currently categorized as "ignorable" need to be ignorable anymore.
I'm volunteering to review PRs that update Options.td to ensure the right ModuleInterface flags are specified for new options.
tshortli
requested review from
hborla,
slavapestov,
xedin,
AnthonyLatsis and
shahmishal
as code owners
|
@swift-ci please test |
tshortli
changed the title
artemcm
approved these changes
Aug 17, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend options should only be printed under
swift-module-flags-ignored:temporarily to prevent condfails for older development compilers that are still in use (as a rule of thumb, swiftinterfaces should be compatible with compilers that are up to 6 months old). None of the frontend flags that are currently categorized as "ignorable" need to be ignorable anymore.I've also added myself as a CODEOWNER to volunteer to review changes to
Options.tdthat might affect swiftinterface compatibility.