Skip to content

Use LLVM runtimes build #67986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Use LLVM runtimes build #67986

wants to merge 5 commits into from

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Aug 17, 2023

LLVM plans to remove the legacy methods for building compiler-rt. This change updates build-script to use LLVM_ENABLE_RUNTIMES to build compiler-rt with the just-built clang instead of the legacy methods.

This does not update the llvm-install-components in build-presets.ini -- this is done on purpose to stress more the migration logic, some of the presets will be updated with a subsequent PRs

Addresses rdar://113972453

@edymtt
Copy link
Contributor Author

edymtt commented Aug 17, 2023

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Aug 17, 2023

Linux is failing, although not for the errors I was expecting

FAILED: CMakeFiles/clang_rt.builtins-x86_64.dir/truncxfhf2.c.o 
/usr/bin/clang --target=x86_64-unknown-linux-gnu -DVISIBILITY_HIDDEN  -resource-dir=/home/build-user/build/buildbot_linux/llvm-linux-x86_64/./lib/clang/13.0.0 -O3 -DNDEBUG -m64 -std=c11 -fPIC -fno-builtin -fvisibility=hidden -fomit-frame-pointer -MD -MT CMakeFiles/clang_rt.builtins-x86_64.dir/truncxfhf2.c.o -MF CMakeFiles/clang_rt.builtins-x86_64.dir/truncxfhf2.c.o.d -o CMakeFiles/clang_rt.builtins-x86_64.dir/truncxfhf2.c.o -c /home/build-user/llvm-project/compiler-rt/lib/builtins/truncxfhf2.c
/home/build-user/llvm-project/compiler-rt/lib/builtins/truncxfhf2.c:19:17: error: _Float16 is not supported on this target
COMPILER_RT_ABI _Float16 __truncxfhf2(long double a) {
                ^
1 error generated.

@edymtt edymtt mentioned this pull request Jan 31, 2024
Closed
@edymtt edymtt force-pushed the edymtt/use-runtimes-build-ter branch from 6789969 to 08e6084 Compare February 14, 2025 17:03
@edymtt
Copy link
Contributor Author

edymtt commented Feb 26, 2025

@swift-ci please test Linux

@edymtt edymtt force-pushed the edymtt/use-runtimes-build-ter branch from 08e6084 to a7f0661 Compare February 26, 2025 21:36
@edymtt
Copy link
Contributor Author

edymtt commented Feb 26, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Feb 26, 2025

@swift-ci please test Apple Silicon

@edymtt
Copy link
Contributor Author

edymtt commented Feb 26, 2025

@swift-ci please build toolchain

@edymtt edymtt force-pushed the edymtt/use-runtimes-build-ter branch from a7f0661 to 738384d Compare February 26, 2025 23:16
@edymtt
Copy link
Contributor Author

edymtt commented Feb 26, 2025

@swift-ci please test

edymtt
edymtt commented Feb 26, 2025
View reviewed changes
@edymtt edymtt force-pushed the edymtt/use-runtimes-build-ter branch from 099d0ec to 03d23bc Compare March 4, 2025 17:26
@edymtt
Use LLVM runtimes build
efce129 
LLVM plans to remove the legacy methods for building compiler-rt. This change updates build-script to use LLVM_ENABLE_RUNTIMES to build compiler-rt with the just-built clang instead of the legacy methods.

This does not update the llvm-install-components in
build-presets.ini -- this is done on purpose to stress more the
migration logic, some of the presets will be updated with a subsequent PRs

Addresses rdar://113972453
@edymtt edymtt force-pushed the edymtt/use-runtimes-build-ter branch from 03d23bc to efce129 Compare March 4, 2025 17:30
@edymtt
Copy link
Contributor Author

edymtt commented Mar 4, 2025

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Mar 4, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Mar 17, 2025

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Mar 17, 2025

@swift-ci please test

@edymtt edymtt force-pushed the edymtt/use-runtimes-build-ter branch from 725c16e to a7bc9bd Compare March 18, 2025 13:47
@edymtt
Copy link
Contributor Author

edymtt commented Mar 18, 2025

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Mar 18, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Mar 24, 2025

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Mar 24, 2025

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Mar 24, 2025

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Mar 31, 2025

Duplicate of #80253

I will test the enablement on top of #80174 instead of maintaining a separate branch without enablement

@edymtt edymtt closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etcwilde etcwilde Awaiting requested review from etcwilde etcwilde will be requested when the pull request is marked ready for review etcwilde is a code owner

@justice-adams-apple justice-adams-apple Awaiting requested review from justice-adams-apple justice-adams-apple will be requested when the pull request is marked ready for review justice-adams-apple is a code owner

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal will be requested when the pull request is marked ready for review shahmishal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edymtt