Skip to content

[AST] NFC: Remove {TokenKinds, Attr}.def.gyb from CMakeLists #67988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 17, 2023

No description provided.

@xedin xedin requested a review from ahoppen August 17, 2023 16:08
@xedin
Copy link
Contributor Author

xedin commented Aug 17, 2023

@swift-ci please clean test

@@ -5,6 +5,5 @@ else()
endif()

set(generated_include_sources
Attr.def.gyb
TokenKinds.def.gyb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TokenKinds.def.gyb doesn’t exist anymore either. I removed both of them in #67666

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I'll remove that as well!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xedin xedin force-pushed the remove-gyb-from-files branch from 5efdf85 to 0625d56 Compare August 17, 2023 16:43
@xedin xedin changed the title [AST] NFC: Remove Attr.def.gyb from CMakeLists [AST] NFC: Remove {TokenKinds, Attr}.def.gyb from CMakeLists Aug 17, 2023
@xedin
Copy link
Contributor Author

xedin commented Aug 17, 2023

@swift-ci please clean test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@xedin xedin merged commit c33f69d into swiftlang:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants