[gyb] Support -o with relative path #67995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a surprising bug where a relative output file path would be interpreted relative to the directory of the `.gyb` file being processed rather than the current working directory upon invocation.
compnerd
reviewed
Aug 21, 2023
| # Allow the template to open files and import .py files relative to its own | ||
| # directory | ||
| saved_cwd = os.getcwd() | ||
| os.chdir(os.path.dirname(os.path.abspath(args.file))) | ||
| sys.path = ['.'] + sys.path |
There was a problem hiding this comment.
Could we use the computed path and prepend that to sys.path instead of of doing the chdir?
There was a problem hiding this comment.
Possibly. That might even be a better solution; amendments welcome.
|
@swift-ci please smoke test |
mininny
pushed a commit
to mininny/swift
that referenced
this pull request
Sep 14, 2023
Fixes a surprising bug where a relative output file path would be interpreted relative to the directory of the `.gyb` file being processed rather than the current working directory upon invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a surprising bug where a relative output file path would be interpreted relative to the directory of the
.gybfile being processed rather than the current working directory upon invocation.