[stdlib] Fix bug in Bit with-overflow arithmetic #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original version would result in a crash for negative results.
| } else { | ||
| return (Bit(rawValue: v.0 % 2)!, true) | ||
| let bitRaw = intResult % 2 + (intResult < 0 ? 2 : 0) |
There was a problem hiding this comment.
I think this might be simpler, and yet produce the same result: let bitRaw = (intResult + 2) % 2.
There was a problem hiding this comment.
Well, that would rely on the precondition that intResult >= -2. This is true for all current calls to the function, but the way it's written now trivially eliminates this precondition.
|
Thank you! Please wrap to 80 columns. |
|
@gribozavr Wrapped to 80 columns. |
gribozavr
added a commit
that referenced
this pull request
Dec 21, 2015
[stdlib] Fix bug in Bit with-overflow arithmetic
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
…05/1 Re-enable swift-numerics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code would crash on negative values.
build-script -R -t.