Skip to content

[5.9][Executors] tryDiagnoseExecutor must survive null witness, when using Backdeploy library #68007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Aug 18, 2023

Description: The recently introduced additional logic to handle missing witnesses was not expecting a null value since in CURRENT stdlib we always have a witness however, in backdeployment we would be missing witnesses and get a null here. We do not test or build backdeployment library in CI, (not even in full tests), which meant this slipped through and was caught in other tests downstream.
Risk: Low, adds missing null check to avoid null pointer dereference.
Reward: Don't crash while building the backdeployment library. There should not be effect on other libraries building though.
Review by: @DougGregor @hborla
Testing:

…ng from Backdeploy library

resolves rdar://114029779
@ktoso ktoso requested a review from a team as a code owner August 18, 2023 14:20
@ktoso
Copy link
Contributor Author

ktoso commented Aug 18, 2023

@swift-ci please test

@ktoso ktoso merged commit bc58dd5 into swiftlang:release/5.9 Aug 18, 2023
@ktoso ktoso deleted the pick-wip-null-witness-executor branch August 18, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants