[5.9][Executors] tryDiagnoseExecutor must survive null witness, when using Backdeploy library #68007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The recently introduced additional logic to handle missing witnesses was not expecting a null value since in CURRENT stdlib we always have a witness however, in backdeployment we would be missing witnesses and get a null here. We do not test or build backdeployment library in CI, (not even in full tests), which meant this slipped through and was caught in other tests downstream.
Risk: Low, adds missing null check to avoid null pointer dereference.
Reward: Don't crash while building the backdeployment library. There should not be effect on other libraries building though.
Review by: @DougGregor @hborla
Testing:
Original PR: [Executors] tryDiagnoseExecutor must survive null witness, when using Backdeploy library #68006
Radar: rdar://114029779