[5.9][TypeChecker/DI] InitAccessors: Treat properties without "initializes" as stored fix default initialization handling #68051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust DI to treat init accessor properties that have only 'accesses' or no restrictions as if they are stored properties, this means that if such property doesn't have a default initializer users would have to reference it explicitly in their custom initializers. We also need to suppress default init synthesis for such cases which would be done in a followup commit. Resolves: rdar://113401979 (cherry picked from commit 11f1b08)
…r properties Fixes a bug were default initializer for an init accessor property hasn't been synthesized even when the property is marked as default initializable. Resolves: rdar://113421273 (cherry picked from commit 645e8df)
…tialization inside of an init accessor (cherry picked from commit 2149a46)
…r properties during default init synthesis Default initializable init properties shouldn't prevent default init synthesis and such properties without anything to initialize should be considered by it. (cherry picked from commit 416bbae)
|
@swift-ci please test |
This aim to compensate the fact that not all of the changes were cherry-picked to 5.9.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
hborla
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #67763, #67769
A couple of improvements to init accessors feature to align implementation with the proposal.
If an init accessor property doesn't initialize any stored properties it has to be initialized explicitly unless it has initializer expression;
Init accessor properties without initializer expressions suppress default initializers;
Scope: Init accessors that do not initialize stored properties.
Main Branch PRs: [DI] Properties with init accessors without "initializes" act as stored #67763, [TypeChecker] InitAccessors: Fix default initialization of init accessor properties #67769
Resolves: rdar://113401979, rdar://113421273
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the suite.
Resolves: rdar://113401979
Resolves: rdar://113421273