RequirementMachine: Fix potential 'pollution' from installing an invalid requirement machine #68055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid requirement machine If the substitution terms of a concrete type symbol contain unresolved name symbols, we have an invalid requirement that is dropped from the minimized signature. In this case, the rewrite system used for minimization cannot be installed as the official rewrite system for this generic signature, because building a rewrite system from the signature will produce a different result. This might be the cause of the crash in rdar://114111159.
slavapestov
force-pushed
the
rdar113943346
branch
from
0dd725a to
595a7a5
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the substitution terms of a concrete type symbol contain unresolved name symbols, we have an invalid requirement that is dropped from the minimized signature. In this case, the rewrite system used for minimization cannot be installed as the official rewrite system for this generic signature, because building a rewrite system from the signature will produce a different result.
This might be the cause of the crash in rdar://114111159.