Skip to content

FIx recently introduced MSVC control path warnings #6808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2017
Merged

FIx recently introduced MSVC control path warnings #6808

merged 1 commit into from
Jan 15, 2017

Conversation

hughbe
Copy link
Contributor

@hughbe hughbe commented Jan 14, 2017

No description provided.

@CodaFi
Copy link
Contributor

CodaFi commented Jan 14, 2017

@swift-ci please smoke test.

@compnerd
Copy link
Member

I think that it may be worth filing a connect ticket for covered switch support in MSVC. It seems that we ended up needing quite a few llvm_unreachable to squelch the warning from MSVC.

@CodaFi
Copy link
Contributor

CodaFi commented Jan 14, 2017

OK, my CI powers are weak this morning apparently:

@swift-ci please smoke test.

@slavapestov slavapestov merged commit 7b2bec5 into swiftlang:master Jan 15, 2017
@hughbe hughbe deleted the msvc-unreachable branch January 20, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants