[CodeCompletion] Delete SanitizeExpr
#68080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
hborla,
slavapestov,
xedin,
bnbarham,
rintaro and
hamishknight
as code owners
ahoppen
force-pushed
the
ahoppen/delete-sanitize-expr
branch
from
c9aa6be to
0a20f25
Compare
|
So happy to see this code gone! |
slavapestov
approved these changes
Aug 23, 2023
xedin
approved these changes
Aug 23, 2023
ahoppen
force-pushed
the
ahoppen/delete-sanitize-expr
branch
from
0a20f25 to
9c2400b
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete a bunch of code that is now dead since we have migrated everything to solver-based completions and then also delete
SanitizeExpr, which shouldn’t be needed anymore.rdar://111756748