[5.9][CodeSynthesis] Make sure that init synthesis expands macros #68100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously both `AreAllStoredPropertiesDefaultInitableRequest` and `HasMemberwiseInitRequest` checked only "current" properties of the type but macro expansions can add new stored and/or init accessor properties that affect this logic so we need to make sure that macro expansions happen and new properties are accounted for. Note that the original idea was to use `getStoredProperties()` but that runs into multiple circularity issues related to lazy properties. Resolves: rdar://112153201 (cherry picked from commit a0573e0)
|
@swift-ci please test |
hborla
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #67721
Previously both
AreAllStoredPropertiesDefaultInitableRequestandHasMemberwiseInitRequestchecked only "current" properties of the type but macro expansions can add new stored and/or
init accessor properties that affect this logic so we need to make sure that macro expansions
happen and new properties are accounted for.
Note that the original idea was to use
getStoredProperties()but that runs into multiple circularityissues related to lazy properties.
Scope: Macro expansions with init accessor properties.
Main Branch PR: [CodeSynthesis] Make sure that init synthesis expands macros #67721
Resolves: rdar://112153201
Risk: Low
Reviewed By: @hborla
Testing: Added test-cases to the suite.
Resolves: rdar://112153201