Skip to content

[send-not-sendable] Eliminate relative includes and add a file header. #68104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

Specifically, the two routines we were importing relatively were:

  1. TypeChecker::conformsToProtocol. I moved this onto a helper routine on SILType.

  2. swift::findOriginalValueType(Expr *). This routine just looks through various implicit conversions to find the original underlying type. I moved it to a helper method on Expr.

Just some cleanups.

Specifically, the two routines we were importing relatively were:

1. TypeChecker::conformsToProtocol. I moved this onto a helper routine on
SILType.

2. swift::findOriginalValueType(Expr *). This routine just looks through various
implicit conversions to find the original underlying type. I moved it to a
helper method on Expr.
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

Timed out in Foundation...

@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

@gottesmm gottesmm merged commit 80f4588 into swiftlang:main Aug 24, 2023
@gottesmm gottesmm deleted the pr-b947139b791a295a9644ab3e87505ccaed9e9259 branch August 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant