[ConstraintSystem] Prevent direct supertype binding generation for key path type vars #68137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
reviewed
Aug 25, 2023
lib/Sema/CSBindings.cpp
Outdated
| if (auto simplifiedSuper = checkTypeOfBinding(TypeVar, supertype)) | ||
| addNewBinding(binding.withType(*simplifiedSuper)); | ||
| // If this is a type variable representing a key path type, | ||
| // try to bind to any direct supertypes. |
There was a problem hiding this comment.
This comment is the opposite of what the condition does...
amritpan
changed the title
amritpan
force-pushed
the
kp-supertypes
branch
from
8a556c6 to
35e02f0
Compare
amritpan
force-pushed
the
kp-supertypes
branch
from
35e02f0 to
0a31b3b
Compare
|
Superseded by #69031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes prevent supertype binding generation for type variables that represent key path expressions because such types require a fully resolved key path (with root and value).