Don't inline non-ossa function into an ossa function in mandatory inlining #68150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
meg-gupta
changed the title
…ining Update the inliner with this check. Inlining non-ossa into ossa can causes unexpected consequences. Fixes rdar://114466605
|
@swift-ci smoke test and merge |
eeckstein
reviewed
Aug 26, 2023
| if apply.parentFunction.hasOwnership && !callee.hasOwnership { | ||
| // Cannot inline a non-ossa function into an ossa function | ||
| return false | ||
| } |
There was a problem hiding this comment.
It would be better to make this check in OptUtils.swift: FullApplySite.canInline
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Nov 1, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Nov 2, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Dec 6, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Dec 7, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Dec 8, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Dec 11, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Dec 12, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Dec 13, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Dec 14, 2023
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Jan 6, 2024
meg-gupta
added a commit
to meg-gupta/swift
that referenced
this pull request
Jan 8, 2024
Catfish-Man
pushed a commit
to Catfish-Man/swift
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the inliner with this check.
Inlining non-ossa into ossa can causes unexpected consequences.
Fixes rdar://114466605