[Explicit Module Builds] Do not attempt to re-load module dependency from interface for index. #68152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A follow-up will be a change to make concrete when Explicitly-Prebuilt dependencies can emit forwarding modules. But that change has a dependency on driver changes for blocklists. In the meantime, this unblocks explicit module builds for affected projects. |
bnbarham
approved these changes
Aug 25, 2023
xymus
approved these changes
Aug 25, 2023
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoIndexRebuilOnExplicitBuild
branch
from
5536f7e to
b09e702
Compare
artemcm
requested review from
ahoppen,
rintaro and
hamishknight
as code owners
|
@swift-ci smoke test |
…from interface for index. An explicit module build compile is unable to do so because it does not have access to the interfaces. Doing this in the first place is a workaround for a known bug, which will require to be solved at the root cause instead (e.g. Deserialization Safety feature). Resolves rdar://113165898
artemcm
force-pushed
the
NoIndexRebuilOnExplicitBuild
branch
from
b09e702 to
e0275f4
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An explicit module build compile is unable to do so because it does not have access to the interfaces. Doing this in the first place is a workaround for a known bug, which will require to be solved at the root cause instead (e.g. Deserialization Safety feature).
Resolves rdar://113165898