[Macros] Add a frontend flag -Rmacro-loading to remark on macro resolution
#68154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olution Macro implementations can come from various locations associated with different search paths. Add a frontend flag `-Rmacro-loading` to emit a remark when each macro implementation module is resolved, providing the kind of macro (shared library, executable, shared library loaded via the plugin server) and appropriate paths. This allows one to tell from the build load which macros are used. Addresses rdar://110780311.
DougGregor
requested review from
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci please smoke test |
bnbarham
approved these changes
Aug 25, 2023
| @@ -25,12 +25,26 @@ | |||
| // RUN: -typecheck -verify \ | |||
| // RUN: -swift-version 5 -enable-experimental-feature Macros \ | |||
| // RUN: -external-plugin-path %t/plugins#%swift-plugin-server \ | |||
| // RUN: -Rmacro-loading -verify-ignore-unknown \ | |||
There was a problem hiding this comment.
Am I just missing where this one is checked? Seems like only macro-loading.txt below is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro implementations can come from various locations associated with different search paths. Add a frontend flag
-Rmacro-loadingto emit a remark when each macro implementation module is resolved, providing the kind of macro (shared library, executable, shared library loaded via the plugin server) and appropriate paths. This allows one to tell from the build load which macros are used.Addresses rdar://110780311.