Skip to content

Update SILOptimizer/character_literals.swift for arm64 #68156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Aug 26, 2023

This very old test used out-dated target flags as a temporary workaround. The test only needs to pass on the most widespread target as a sanity check.

This very old test used out-dated target flags as a temporary
workaround. The test only needs to pass on the most widespread target
as a sanity check.
@atrick atrick requested a review from aschwaighofer August 26, 2023 02:29
@atrick
Copy link
Contributor Author

atrick commented Aug 26, 2023

@swift-ci test

@compnerd
Copy link
Member

@atrick x86_64 still is the most widespread architecture - that is the primary architecture on Windows, which is ~70% of the market. This currently reduces coverage on Windows. Can you at least fork the test and add a windows variant?

@atrick atrick merged commit 129d385 into swiftlang:main Aug 29, 2023
@atrick atrick deleted the update-test-arm64 branch August 29, 2023 02:18
@atrick
Copy link
Contributor Author

atrick commented Sep 1, 2023

@atrick x86_64 still is the most widespread architecture - that is the primary architecture on Windows, which is ~70% of the market. This currently reduces coverage on Windows. Can you at least fork the test and add a windows variant?

@compnerd the test doesn't actually target any architecture or platform. My point was only that this change was a big net gain in CI coverage. Nonetheless, we shouldn't be so lazy about Windows coverage: #68286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants