[send-non-sendable] Convert some of the concurrency tests that test targeted concurrency to also test complete and complete + sis #68195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
gottesmm
force-pushed
the
pr-1f647dd0c785123c93b7a25e78addfca45c2b473
branch
from
4910a6f to
0df1ab8
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows platform |
…tional check prefixes to the DiagnosticVerifier.
This enables one to use varying prefixes when checking diagnostics with the
DiagnosticVerifier. So for instance, I can make a test work both with and
without send-non-sendable enabled by adding additional prefixes. As an example:
```swift
// RUN: %target-swift-frontend ... -verify-additional-prefix no-sns-
// RUN: %target-swift-frontend ... -verify-additional-prefix sns-
let x = ... // expected-error {{This is always checked no matter what prefixes I added}}
let y = ... // expected-no-sns-error {{This is only checked if send non sendable is disabled}}
let z = ... // expected-sns-error {{This is only checked if send non sendable is enabled}}
let w = ... // expected-no-sns-error {{This is checked for a specific error when sns is disabled...}}
// expected-sns-error @-1 {{and for a different error when sns is enabled}}
```
rdar://114643840
…ll concurrency modes as appropriate. This means that: 1. In test cases where minimal is the default (swift 5 without -warn-concurrency), I added RUN lines for targeted, complete, and complete + sns. 2. In test cases where complete is the default (swift 6, -warn-concurrency, specified complete with -strict-concurrency), I added a send non-sendable run line. In each of these cases, I added additional expected-* lines as appropriate so the tests can compile in each mode successfully.
… main Concurrency test directory. I added a sendnonsendable_ prefix to the test names so we still know they are for sendnonsendable.
gottesmm
force-pushed
the
pr-1f647dd0c785123c93b7a25e78addfca45c2b473
branch
from
0df1ab8 to
e8448ee
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test linux platform |
1 similar comment
|
@swift-ci smoke test linux platform |
beccadax
added a commit
that referenced
this pull request
Sep 13, 2024
This handy feature was added in #68195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, there are three commits: