Skip to content

[CSSimplify] Rework detection of missing/extraneous arguments in closure #68215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 30, 2023

Checking type variables is no longer necessary because constraint
system now stores types of all closures it encountered, this makes
detection logic more reliable as well.

Resolves: rdar://112426330

Checking type variables is no longer necessary because constraint
system now stores types of all closures it encountered, this makes
detection logic more reliable as well.

Resolves: rdar://112426330
@xedin xedin requested a review from hborla as a code owner August 30, 2023 17:49
@xedin
Copy link
Contributor Author

xedin commented Aug 30, 2023

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Aug 31, 2023

@swift-ci please test Linux platform

@xedin xedin requested a review from hamishknight August 31, 2023 17:37
Copy link
Contributor

@hamishknight hamishknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xedin xedin merged commit ed046e5 into swiftlang:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants