[stdlib] Set PYTHONIOENCODING when building the stdlib #68218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubuntu 18.04 seems to be defaulting to 'ascii', causing an error when using line-directive combined with the utf-8 diagnostic output used when early swift syntax is enabled.
This was disabled due to: ``` Unable to decode the command from the command line: UnicodeEncodeError: 'utf-8' codec can't encode characters in position 13-20: surrogates not allowed ``` Note that this error isn't in `line-directive`, but in Python decoding surrogates from the command line. Not sure why that's not allowed, but printing from within a script works so change to that. We already set `PYTHONIOENCODING=UTF8` in the environment in `test/lit.cfg`, which makes sure stdout is UTF8 as opposed to ASCII. Resolves rdar://92613094.
|
@swift-ci Please Build Toolchain Ubuntu 18.04 |
|
@swift-ci please test |
PYTHONIOENCODING is already specified in `lit.cfg`. The change that added this also added the `<`, which is what actually made this pass - PYTHONIOENCODING only overrides the encoding of stdin/stdout/stderr.
|
@xymus for the last commit |
|
@swift-ci please smoke test |
xymus
approved these changes
Aug 30, 2023
|
@swift-ci please smoke test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 18.04 seems to be defaulting to 'ascii', causing an error when using line-directive combined with the utf-8 diagnostic output used when early swift syntax is enabled.
Also fix up a validation-test while I'm here.